Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Update clang-format version to v4.11.0 for Velox backend #5035

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

yma11
Copy link
Contributor

@yma11 yma11 commented Mar 20, 2024

What changes were proposed in this pull request?

jidicula/[email protected] doesn't meet Apache criteria and will cause following error. So we upgrade to v4.11.0 which is also used by CH backend.
image

How was this patch tested?

CI

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

@zhouyuan zhouyuan merged commit 01cce51 into apache:main Mar 20, 2024
16 of 20 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_5035_time.csv log/native_master_03_19_2024_e977d79e3_time.csv difference percentage
q1 36.13 36.21 0.082 100.23%
q2 23.43 24.11 0.674 102.88%
q3 37.28 36.64 -0.639 98.29%
q4 38.15 38.02 -0.130 99.66%
q5 67.88 69.07 1.191 101.75%
q6 5.82 5.91 0.085 101.46%
q7 82.74 82.31 -0.433 99.48%
q8 84.98 85.26 0.286 100.34%
q9 126.41 121.93 -4.485 96.45%
q10 46.20 45.61 -0.590 98.72%
q11 20.02 20.57 0.546 102.73%
q12 27.05 28.32 1.269 104.69%
q13 46.97 47.17 0.193 100.41%
q14 22.84 16.86 -5.980 73.81%
q15 30.69 31.19 0.506 101.65%
q16 13.70 16.26 2.564 118.72%
q17 100.69 99.14 -1.548 98.46%
q18 139.98 142.77 2.788 101.99%
q19 13.79 14.68 0.899 106.52%
q20 26.68 28.29 1.607 106.02%
q21 229.73 227.96 -1.767 99.23%
q22 14.28 14.00 -0.280 98.04%
total 1235.44 1232.28 -3.164 99.74%

@yma11 yma11 deleted the clang-format branch April 23, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants